• src/sbbs3/putnode.cpp

    From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Monday, December 02, 2024 00:29:20
    https://gitlab.synchro.net/main/sbbs/-/commit/b1522b364f336ade61d4249c
    Modified Files:
    src/sbbs3/putnode.cpp
    Log Message:
    Support @-codes in NodeAction text.dat strings

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Friday, December 06, 2024 17:38:28
    https://gitlab.synchro.net/main/sbbs/-/commit/b6062fa38882d4e96f31772c
    Modified Files:
    src/sbbs3/putnode.cpp
    Log Message:
    More nodefile_mutex fixes

    Need to unlock the mutex before calling errormsg().

    Need unlock the mutex in error path of unlocknodedat().

    I'm not clear why this would, but it might resolve CID 515601 which looks
    like false positive to me: getnmsg()->putnodedat() should never leave nodefile_mutex locked.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Friday, March 06, 2026 21:58:36
    https://gitlab.synchro.net/main/sbbs/-/commit/5b78919802d432db1944fbc4
    Modified Files:
    src/sbbs3/putnode.cpp
    Log Message:
    Add some log messages for other putnodedat() failure cases

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Saturday, March 07, 2026 19:47:07
    https://gitlab.synchro.net/main/sbbs/-/commit/30cdbb4a688b11611693ff8e
    Modified Files:
    src/sbbs3/putnode.cpp
    Log Message:
    putnodedat() will no longer open the node.dab if it's already open

    putnodedat() is not supposed to be called without first calling getnodedat() which locks the file (and leaves it open), so having putnodedat() open the file (if not already open) didn't make any sense. Log an error if the file isn't already open instead. This function wasn't locking the node.dab record in this case anyway, so it was broken in that regard. I placed a breakpoint in the
    open logic here and it never hit, so should be fine to remove.

    unlocknodedat() will now log an error if called with a unopened nodefile.

    Also using [F]CLOSE_OPEN_FILE function-like macros to simplify code

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net